feat: 🎸 Reply support & other changes#12
Merged
Conversation
BREAKING CHANGE: 🧨 Updated Repo name
BREAKING CHANGE: 🧨 updated repo name
Closed
There was a problem hiding this comment.
Pull request overview
This pull request implements reply support for the LINE bridge and renames the project from mautrix-line-messenger to matrix-line-messenger. The changes enable users to reply to messages in both directions (LINE → Matrix and Matrix → LINE) and updates all references throughout the codebase to reflect the new project name.
Key changes:
- Added reply support with new fields in the Message struct and logic to resolve reply relationships in both directions
- Changed SendMessage to return the sent message for proper ID tracking
- Renamed the project module and all import paths from
mautrix-line-messengertomatrix-line-messenger
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/line/structs.go | Added reply-related fields (RelatedMessageID, MessageRelationType, RelatedMessageServiceCode) to Message struct |
| pkg/line/methods.go | Modified SendMessage to return the sent Message object instead of just error |
| pkg/connector/client.go | Implemented resolveReplyRelatesTo for incoming replies, added reply handling for outgoing messages, added RelatesTo to all message types, changed sticker MsgType from MsgImage to MsgFile |
| pkg/line/secret/secret.go | Updated import path to new project name |
| pkg/line/client.go | Updated import paths to new project name |
| pkg/e2ee/manager.go | Updated import paths to new project name |
| pkg/connector/connector.go | Updated import paths, bridge type, step IDs, and removed NetworkIcon URL |
| go.mod | Changed module name to new project name |
| docker-run.sh | Updated binary name from mautrix-line to matrix-line |
| docker-compose.yml | Renamed service and reformatted with consistent indentation |
| cmd/matrix-line/main.go | Updated import path, bridge name, and URL |
| build.sh | Updated build command to use new cmd directory |
| README.md | Updated all references to new project name, marked reply support as complete, added usage documentation |
| Dockerfile | Updated build command and binary copy to use new name |
| .pre-commit-config.yaml | Updated local import path |
| .gitignore | Updated binary name pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+65
to
+71
| docker compose up --build (-d) | ||
| ``` | ||
|
|
||
| To run the bridge without rebuilding, use: | ||
|
|
||
| ```bash | ||
| docker compose up (-d) |
There was a problem hiding this comment.
The documentation shows incorrect command syntax. The flag syntax (-d) in parentheses is not valid shell syntax. It should be either included as part of the command docker compose up --build -d or shown as an optional flag more clearly.
Suggested change
| docker compose up --build (-d) | |
| ``` | |
| To run the bridge without rebuilding, use: | |
| ```bash | |
| docker compose up (-d) | |
| docker compose up --build -d | |
| ``` | |
| To run the bridge without rebuilding, use: | |
| ```bash | |
| docker compose up -d |
Updated readme Step 6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.